Bug 158824

Summary: Expose _shouldExpandToViewHeightForAutoLayout SPI on WKWebView
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, enrica, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Tim Horton
Reported 2016-06-15 19:07:03 PDT
Expose _shouldExpandToViewHeightForAutoLayout SPI on WKWebView
Attachments
Patch (8.91 KB, patch)
2016-06-15 19:07 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-06-15 19:07:27 PDT
Created attachment 281425 [details] Patch
Tim Horton
Comment 2 2016-06-15 19:07:49 PDT
rdar://problem/23713857
WebKit Commit Bot
Comment 3 2016-06-15 19:09:13 PDT
Attachment 281425 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:146: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:159: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 4 2016-06-15 19:15:47 PDT
Comment on attachment 281425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281425&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:195 > +@property (nonatomic, setter=_setShouldExpandToViewHeightForAutoLayout:) BOOL _shouldExpandToViewHeightForAutoLayout WK_AVAILABLE(WK_MAC_TBA, NA); Should this say _setShouldExpand*Content*ToViewHeightForAutoLayout ? Otherwise it seems to be saying that the WKWebView should expand to something.
Tim Horton
Comment 5 2016-06-15 19:20:28 PDT
http://trac.webkit.org/changeset/202120
Note You need to log in before you can comment on or make changes to this bug.