| Summary: | [iOS] Play glyph is pixelated when the page zoom is large | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
| Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | iPhone / iPad | ||||||||||
| OS: | iOS 9.3 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 281308 [details]
Patch
Comment on attachment 281308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281308&action=review > Source/WebCore/ChangeLog:11 > + Use the same technique that we use to scale the video controls by using a combination > + of CSS "zoom" and "transform" properties to have the video play glyph scaled at its > + native size regardless of page zoom. Should we make a helper function for this to avoid repeating the code? (In reply to comment #3) > Comment on attachment 281308 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281308&action=review > > > Source/WebCore/ChangeLog:11 > > + Use the same technique that we use to scale the video controls by using a combination > > + of CSS "zoom" and "transform" properties to have the video play glyph scaled at its > > + native size regardless of page zoom. > > Should we make a helper function for this to avoid repeating the code? Sure thing. I'll add an inline function to the `scaleFactor` setter. Created attachment 281310 [details]
Patch for landing
Comment on attachment 281310 [details] Patch for landing Clearing flags on attachment: 281310 Committed r202079: <http://trac.webkit.org/changeset/202079> All reviewed patches have been landed. Closing bug. |
Created attachment 281307 [details] Testcase See the attached test case which has a <video> element with a rather large viewport width forcing a lot of page zoom. In that situation, the play glyph over the video is very pixelated.