Bug 158754

Summary: The Array species constructor watchpoints should be created the first time they are needed rather than on creation
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
benjamin: review+
Micro-benchmark results none

Keith Miller
Reported 2016-06-14 14:25:25 PDT
The Array species constructor watchpoints should be created the first time they are needed rather than on creation
Attachments
Patch (18.71 KB, patch)
2016-06-14 14:41 PDT, Keith Miller 		benjamin: review+
DetailsFormatted DiffDiff
Micro-benchmark results (885 bytes, text/plain)
2016-06-14 14:42 PDT, Keith Miller 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-06-14 14:41:32 PDT
Created attachment 281281 [details] Patch
Keith Miller
Comment 2 2016-06-14 14:42:28 PDT
Created attachment 281282 [details] Micro-benchmark results
Benjamin Poulain
Comment 3 2016-06-14 14:59:08 PDT
Comment on attachment 281281 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281281&action=review > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1110 > + // And that Array[Symbol.species] is the primordial GetterSetter. And -> and
Benjamin Poulain
Comment 4 2016-06-14 15:00:19 PDT
Maybe add 2 tests where you warm up with-the-original-constructor/without-species, then modify, and run a loop again verifying the changes.
Keith Miller
Comment 5 2016-06-14 15:32:33 PDT
Committed r202067: <http://trac.webkit.org/changeset/202067>
Note You need to log in before you can comment on or make changes to this bug.