Summary: | The Array species constructor watchpoints should be created the first time they are needed rather than on creation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||
Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, mark.lam, msaboff, saam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Keith Miller
2016-06-14 14:25:25 PDT
Created attachment 281281 [details]
Patch
Created attachment 281282 [details]
Micro-benchmark results
Comment on attachment 281281 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281281&action=review > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1110 > + // And that Array[Symbol.species] is the primordial GetterSetter. And -> and Maybe add 2 tests where you warm up with-the-original-constructor/without-species, then modify, and run a loop again verifying the changes. Committed r202067: <http://trac.webkit.org/changeset/202067> |