Summary: | REGRESSION (r202020): El Capitan CMake Debug build broken | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, aestes, bfulgham, commit-queue, dbates, joepeck, lforschler | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=158716 | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2016-06-14 10:59:33 PDT
Created attachment 281266 [details]
Patch v1
Comment on attachment 281266 [details] Patch v1 Clearing flags on attachment: 281266 Committed r202056: <http://trac.webkit.org/changeset/202056> All reviewed patches have been landed. Closing bug. This is fixed (no longer hitting the error): <https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/5881> Here's the last build with the error for this bug: <https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/5880> In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/DumpRenderTreeCommon.cpp:2: In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/DumpRenderTree.h:38: /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/mac/DumpRenderTreeMac.h:55:44: error: expected function body after function declarator WebView *createWebViewAndOffscreenWindow() NS_RETURNS_RETAINED; ^ 1 error generated. make[2]: *** [Tools/DumpRenderTree/CMakeFiles/DumpRenderTree.dir/DumpRenderTreeCommon.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/PixelDumpSupport.cpp:33: In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/DumpRenderTree.h:38: /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/mac/DumpRenderTreeMac.h:55:44: error: expected function body after function declarator WebView *createWebViewAndOffscreenWindow() NS_RETURNS_RETAINED; ^ 1 error generated. Oops, DumpRenderTree is now missing the common DumpRenderTree_SOURCES from Tools/DumpRenderTree/CMakeLists.txt. Going to attempt a build fix. (In reply to comment #5) > Oops, DumpRenderTree is now missing the common DumpRenderTree_SOURCES from > Tools/DumpRenderTree/CMakeLists.txt. > > Going to attempt a build fix. And TestNetscapePlugin had the same issue. Attempt a build fix: Committed r202060: <http://trac.webkit.org/changeset/202060> (In reply to comment #6) > (In reply to comment #5) > > Oops, DumpRenderTree is now missing the common DumpRenderTree_SOURCES from > > Tools/DumpRenderTree/CMakeLists.txt. > > > > Going to attempt a build fix. > > And TestNetscapePlugin had the same issue. > > Attempt a build fix: > > Committed r202060: <http://trac.webkit.org/changeset/202060> The build fix would have worked if not for a silly typo, fixed here: Committed r202065: <http://trac.webkit.org/changeset/202065> |