Bug 158726

Summary:

Tests don't work in iOS Simulator when ASan is enabled

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dburkart, ddkilzer, glenn, lforschler

Priority:

Keywords:

InRadar

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2016-06-13 23:15:24 PDT

LayoutTestRelay terminates right away.

Comment 1 Alexey Proskuryakov 2016-06-13 23:19:24 PDT

Created attachment 281236 [details]
proposed fix

Comment 2 David Kilzer (:ddkilzer) 2016-06-14 16:03:42 PDT

<rdar://problem/20696702>

Comment 3 David Kilzer (:ddkilzer) 2016-06-14 16:07:23 PDT

Comment on attachment 281236 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281236&action=review

r=me

> Tools/Scripts/webkitpy/port/driver.py:325
> +        # FIXME: DYLD_* variables should be Mac-only. Even iOS Simulator doesn't need them, as LayoutTestRelay is a host binary.

Please file a bug and add it to the comment to track the issue.

Comment 4 Alexey Proskuryakov 2016-06-14 16:13:57 PDT

Comment on attachment 281236 [details]
proposed fix

Discussed it with David in person - I don't want to file a bug about this code reorganization idea, as I don't see how such a bug can be useful.

Comment 5 WebKit Commit Bot 2016-06-14 16:36:54 PDT

Comment on attachment 281236 [details]
proposed fix

Clearing flags on attachment: 281236

Committed r202071: <http://trac.webkit.org/changeset/202071>

Comment 6 WebKit Commit Bot 2016-06-14 16:36:58 PDT

All reviewed patches have been landed.  Closing bug.