Bug 158726

Summary:

Tests don't work in iOS Simulator when ASan is enabled

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dburkart, ddkilzer, glenn, lforschler

Priority:

Keywords:

InRadar

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Alexey Proskuryakov

Reported 2016-06-13 23:15:24 PDT

LayoutTestRelay terminates right away.

Attachments
proposed fix (2.41 KB, patch) 2016-06-13 23:19 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2016-06-13 23:19:24 PDT

Created attachment 281236 [details] proposed fix

David Kilzer (:ddkilzer)

Comment 2 2016-06-14 16:03:42 PDT

<rdar://problem/20696702>

David Kilzer (:ddkilzer)

Comment 3 2016-06-14 16:07:23 PDT

Comment on attachment 281236 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=281236&action=review r=me > Tools/Scripts/webkitpy/port/driver.py:325 > + # FIXME: DYLD_* variables should be Mac-only. Even iOS Simulator doesn't need them, as LayoutTestRelay is a host binary. Please file a bug and add it to the comment to track the issue.

Alexey Proskuryakov

Comment 4 2016-06-14 16:13:57 PDT

Comment on attachment 281236 [details] proposed fix Discussed it with David in person - I don't want to file a bug about this code reorganization idea, as I don't see how such a bug can be useful.

WebKit Commit Bot

Comment 5 2016-06-14 16:36:54 PDT

Comment on attachment 281236 [details] proposed fix Clearing flags on attachment: 281236 Committed r202071: <http://trac.webkit.org/changeset/202071>

WebKit Commit Bot

Comment 6 2016-06-14 16:36:58 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.