Summary: | FTL::Output methods should be out-of-line whenever possible | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, saam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2016-06-13 13:56:54 PDT
Created attachment 281199 [details]
the patch
Attachment 281199 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:249: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:115: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:150: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:155: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:156: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:162: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:164: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:170: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:171: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:171: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:173: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:175: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:176: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:177: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:326: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:327: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:328: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:329: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:340: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:391: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:395: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:400: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:404: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 23 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 281204 [details]
patch for landing
Attachment 281204 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:249: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:340: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 281206 [details]
even better
Removed some more pointless parameter names from FTLOutput.h. I think that add(Lvalue, LValue) looks better than add(LValue left, LValue right). I retained the parameter names in cases where they make sense, like shl(LValue, LValue shiftAmount).
Attachment 281206 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:249: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:339: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Landed in http://trac.webkit.org/changeset/202007 |