Bug 15868

Summary: build-testkjs reports grep's exit code instead of xcodebuild (thus never fails!)
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Regression
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
the fix mrowe: review+

Eric Seidel (no email)
Reported 2007-11-06 20:57:21 PST
build-testkjs reports grep's exit code instead of xcodebuild (thus never fails!) This is the trouble line: $result = system "sh", "-c", 'xcodebuild -project JavaScriptCore.xcodeproj -target testkjs "$@" | grep -v setenv', "xcodebuild", @options, @ARGV; I'm sure there is some slick way to grab the exit code from the other side of the pipe. But I'm rather tired and going to cop-out and file this bug instead.
Attachments
the fix (1.21 KB, patch)
2007-11-06 21:22 PST, Eric Seidel (no email) 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-11-06 21:22:38 PST
Created attachment 17084 [details] the fix
Mark Rowe (bdash)
Comment 2 2007-11-06 21:26:35 PST
Comment on attachment 17084 [details] the fix The patch claims I have already reviewed this, so here is an r=me in Bugzilla too.
Eric Seidel (no email)
Comment 3 2007-11-06 21:31:23 PST
Landed as r27497
Note You need to log in before you can comment on or make changes to this bug.