Bug 158626

Summary: Web Inspector: 1px gap above timeline progress view
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, jond, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P3 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] 1px gap between nav bar and progress view
none
Patch
none
[Patch] Proposed Fix none

Matt Baker
Reported 2016-06-10 11:33:29 PDT
Created attachment 281019 [details] [Image] 1px gap between nav bar and progress view * SUMMARY 1px gap above timeline progress view (see attachment). Regressed in http://trac.webkit.org/changeset/201538.
Attachments
[Image] 1px gap between nav bar and progress view (125.08 KB, image/png)
2016-06-10 11:33 PDT, Matt Baker 		no flags
Details
Patch (1.14 KB, patch)
2016-06-10 11:37 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (1.48 KB, patch)
2016-06-10 11:40 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2016-06-10 11:37:14 PDT
Created attachment 281021 [details] Patch
Radar WebKit Bug Importer
Comment 2 2016-06-10 11:37:41 PDT
<rdar://problem/26744112>
Matt Baker
Comment 3 2016-06-10 11:39:02 PDT
Comment on attachment 281021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281021&action=review > Source/WebInspectorUI/UserInterface/Views/ProfileView.css:-37 > - This is already addressed in another patch: https://bugs.webkit.org/show_bug.cgi?id=158624. The correct fix is to adjust the top of the progress view. I have a patch for that.
Matt Baker
Comment 4 2016-06-10 11:40:11 PDT
Created attachment 281022 [details] [Patch] Proposed Fix
Matt Baker
Comment 5 2016-06-10 11:43:18 PDT
*** Bug 158627 has been marked as a duplicate of this bug. ***
Nikita Vasilyev
Comment 6 2016-06-10 11:46:21 PDT
(In reply to comment #3) > Comment on attachment 281021 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281021&action=review > > > Source/WebInspectorUI/UserInterface/Views/ProfileView.css:-37 > > - > > This is already addressed in another patch: > https://bugs.webkit.org/show_bug.cgi?id=158624. The correct fix is to adjust > the top of the progress view. I have a patch for that. You're right. Your patch looks good.
Joseph Pecoraro
Comment 7 2016-06-10 12:18:33 PDT
Comment on attachment 281022 [details] [Patch] Proposed Fix r=me
Nikita Vasilyev
Comment 8 2016-06-10 12:26:37 PDT
Comment on attachment 281022 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281022&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.css:-69 > - top: 30px; This matches the height of .navigation-bar. We should probably introduce a variable, like --navigation-bar-height.
WebKit Commit Bot
Comment 9 2016-06-10 12:41:06 PDT
Comment on attachment 281022 [details] [Patch] Proposed Fix Clearing flags on attachment: 281022 Committed r201935: <http://trac.webkit.org/changeset/201935>
WebKit Commit Bot
Comment 10 2016-06-10 12:41:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.