Bug 158626

Summary:

Web Inspector: 1px gap above timeline progress view

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, joepeck, jond, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] 1px gap between nav bar and progress view	none
Patch	none
[Patch] Proposed Fix	none

Description Matt Baker 2016-06-10 11:33:29 PDT

Created attachment 281019 [details]
[Image] 1px gap between nav bar and progress view

* SUMMARY
1px gap above timeline progress view (see attachment).

Regressed in http://trac.webkit.org/changeset/201538.

Comment 1 Nikita Vasilyev 2016-06-10 11:37:14 PDT

Created attachment 281021 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2016-06-10 11:37:41 PDT

<rdar://problem/26744112>

Comment 3 Matt Baker 2016-06-10 11:39:02 PDT

Comment on attachment 281021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281021&action=review

> Source/WebInspectorUI/UserInterface/Views/ProfileView.css:-37
> -

This is already addressed in another patch: https://bugs.webkit.org/show_bug.cgi?id=158624. The correct fix is to adjust the top of the progress view. I have a patch for that.

Comment 4 Matt Baker 2016-06-10 11:40:11 PDT

Created attachment 281022 [details]
[Patch] Proposed Fix

Comment 5 Matt Baker 2016-06-10 11:43:18 PDT

*** Bug 158627 has been marked as a duplicate of this bug. ***

Comment 6 Nikita Vasilyev 2016-06-10 11:46:21 PDT

(In reply to comment #3)
> Comment on attachment 281021 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281021&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/ProfileView.css:-37
> > -
> 
> This is already addressed in another patch:
> https://bugs.webkit.org/show_bug.cgi?id=158624. The correct fix is to adjust
> the top of the progress view. I have a patch for that.

You're right.

Your patch looks good.

Comment 7 Joseph Pecoraro 2016-06-10 12:18:33 PDT

Comment on attachment 281022 [details]
[Patch] Proposed Fix

r=me

Comment 8 Nikita Vasilyev 2016-06-10 12:26:37 PDT

Comment on attachment 281022 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281022&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.css:-69
> -    top: 30px;

This matches the height of .navigation-bar. We should probably introduce a variable, like
--navigation-bar-height.

Comment 9 WebKit Commit Bot 2016-06-10 12:41:06 PDT

Comment on attachment 281022 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 281022

Committed r201935: <http://trac.webkit.org/changeset/201935>

Comment 10 WebKit Commit Bot 2016-06-10 12:41:09 PDT

All reviewed patches have been landed.  Closing bug.