Bug 158606

Summary: ErrorEvent / ProgressEvent should be exposed to workers
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, darin, esprehn+autocc, kangil.han, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Comment 1 Chris Dumez 2016-06-09 22:14:26 PDT 
Created attachment 280992 [details]
Patch
Comment 2 Alex Christensen 2016-06-10 00:15:55 PDT 
Comment on attachment 280992 [details]
Patch

Actually, I'm not sure.  ErrorEvent::createForBindings uses an AtomicString, and can't that only be used from the main thread?
Comment 3 Chris Dumez 2016-06-10 07:23:54 PDT 
(In reply to comment #2)
> Comment on attachment 280992 [details]
> Patch
> 
> Actually, I'm not sure.  ErrorEvent::createForBindings uses an AtomicString,
> and can't that only be used from the main thread?

Using AtomicString in other threads is fine. What you cannot do is pass them to other threads. AtomicStrings are per thread AFAIK.
Comment 4 Brady Eidson 2016-06-10 09:04:31 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 280992 [details]
> > Patch
> > 
> > Actually, I'm not sure.  ErrorEvent::createForBindings uses an AtomicString,
> > and can't that only be used from the main thread?
> 
> Using AtomicString in other threads is fine. What you cannot do is pass them
> to other threads. AtomicStrings are per thread AFAIK.

This is correct - Each thread has its own AtomicString table, and its safe to use them within a given thread.
Comment 5 Chris Dumez 2016-06-10 09:18:14 PDT 
Comment on attachment 280992 [details]
Patch

Clearing flags on attachment: 280992

Committed r201926: <http://trac.webkit.org/changeset/201926>
Comment 6 Chris Dumez 2016-06-10 09:18:18 PDT 
All reviewed patches have been landed.  Closing bug.