Bug 158598

Summary:

Web Inspector: Cleanup InspectorIndexedDBAgent a bit

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2016-06-09 19:36:05 PDT

Cleanup InspectorIndexedDBAgent a bit

Comment 1 Joseph Pecoraro 2016-06-09 19:37:04 PDT

Created attachment 280976 [details]
[PATCH] Proposed Fix

Comment 2 Darin Adler 2016-06-09 20:20:41 PDT

Comment on attachment 280976 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=280976&action=review

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:163
> +    Ref<OpenDatabaseCallback> callback = OpenDatabaseCallback::create(this);

I suggest using auto rather than repeating the type name twice here. Or just doing this inside the addEventListener call.

I think there should be a lot more use of auto elsewhere in this file.

Comment 3 WebKit Commit Bot 2016-06-10 13:58:06 PDT

Comment on attachment 280976 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 280976

Committed r201939: <http://trac.webkit.org/changeset/201939>

Comment 4 WebKit Commit Bot 2016-06-10 13:58:10 PDT

All reviewed patches have been landed.  Closing bug.