WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
158598
Web Inspector: Cleanup InspectorIndexedDBAgent a bit
https://bugs.webkit.org/show_bug.cgi?id=158598
Summary
Web Inspector: Cleanup InspectorIndexedDBAgent a bit
Joseph Pecoraro
Reported
2016-06-09 19:36:05 PDT
Cleanup InspectorIndexedDBAgent a bit
Attachments
[PATCH] Proposed Fix
(7.41 KB, patch)
2016-06-09 19:37 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2016-06-09 19:37:04 PDT
Created
attachment 280976
[details]
[PATCH] Proposed Fix
Darin Adler
Comment 2
2016-06-09 20:20:41 PDT
Comment on
attachment 280976
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=280976&action=review
> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:163 > + Ref<OpenDatabaseCallback> callback = OpenDatabaseCallback::create(this);
I suggest using auto rather than repeating the type name twice here. Or just doing this inside the addEventListener call. I think there should be a lot more use of auto elsewhere in this file.
WebKit Commit Bot
Comment 3
2016-06-10 13:58:06 PDT
Comment on
attachment 280976
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 280976 Committed
r201939
: <
http://trac.webkit.org/changeset/201939
>
WebKit Commit Bot
Comment 4
2016-06-10 13:58:10 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug