Bug 158598 - Web Inspector: Cleanup InspectorIndexedDBAgent a bit
Summary: Web Inspector: Cleanup InspectorIndexedDBAgent a bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-06-09 19:36 PDT by Joseph Pecoraro
Modified: 2016-06-10 13:58 PDT (History)
7 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (7.41 KB, patch)
2016-06-09 19:37 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-06-09 19:36:05 PDT
Cleanup InspectorIndexedDBAgent a bit
Comment 1 Joseph Pecoraro 2016-06-09 19:37:04 PDT
Created attachment 280976 [details]
[PATCH] Proposed Fix
Comment 2 Darin Adler 2016-06-09 20:20:41 PDT
Comment on attachment 280976 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=280976&action=review

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:163
> +    Ref<OpenDatabaseCallback> callback = OpenDatabaseCallback::create(this);

I suggest using auto rather than repeating the type name twice here. Or just doing this inside the addEventListener call.

I think there should be a lot more use of auto elsewhere in this file.
Comment 3 WebKit Commit Bot 2016-06-10 13:58:06 PDT
Comment on attachment 280976 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 280976

Committed r201939: <http://trac.webkit.org/changeset/201939>
Comment 4 WebKit Commit Bot 2016-06-10 13:58:10 PDT
All reviewed patches have been landed.  Closing bug.