Bug 158591

Summary:

Rare failure in stress/v8-deltablue-strict.js.ftl-eager

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	saam: review+

Description Filip Pizlo 2016-06-09 16:01:49 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2016-06-09 16:20:50 PDT

Created attachment 280964 [details]
the patch

Comment 2 Saam Barati 2016-06-09 16:33:55 PDT

Comment on attachment 280964 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280964&action=review

> Source/JavaScriptCore/dfg/DFGNode.h:546
> +    void convertToPutByOffset(StorageAccessData& data, Edge storage, Edge childEdge)

I'd call this base

Comment 3 Filip Pizlo 2016-06-09 18:56:47 PDT

(In reply to comment #2)
> Comment on attachment 280964 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280964&action=review
> 
> > Source/JavaScriptCore/dfg/DFGNode.h:546
> > +    void convertToPutByOffset(StorageAccessData& data, Edge storage, Edge childEdge)
> 
> I'd call this base

Fixed!

Comment 4 Filip Pizlo 2016-06-09 19:02:22 PDT

Landed in http://trac.webkit.org/changeset/201900