Bug 158588

Summary: Clean up EditorClient lifetime
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=158401
Bug Depends on: 158609    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch andersca: review+

Description Alex Christensen 2016-06-09 15:37:18 PDT 
Clean up EditorClient lifetime
Comment 1 Alex Christensen 2016-06-09 15:47:12 PDT 
Created attachment 280960 [details]
Patch
Comment 2 Alex Christensen 2016-06-09 16:23:04 PDT 
Created attachment 280966 [details]
Patch
Comment 3 Alex Christensen 2016-06-09 16:32:20 PDT 
Created attachment 280967 [details]
Patch
Comment 4 Alex Christensen 2016-06-09 16:53:51 PDT 
http://trac.webkit.org/changeset/201894
Comment 5 WebKit Commit Bot 2016-06-09 22:10:45 PDT 
Re-opened since this is blocked by bug 158609
Comment 6 Ryan Haddad 2016-06-09 22:12:19 PDT 
This change appears to have broken the Windows build.

https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/78309/steps/compile-webkit/logs/stdio
Comment 7 Alex Christensen 2016-06-09 22:17:09 PDT 
I guess I didn't wait for all the EWS bots :(
http://trac.webkit.org/changeset/201905 fixed it.
Comment 8 Alex Christensen 2016-06-09 22:33:41 PDT 
and r201909
Comment 9 Alexey Proskuryakov 2016-06-09 23:43:05 PDT 
I wonder if this fixed bug 158401!