| Summary: | atob() / btoa() API should be exposed to workers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beidson, cdumez, commit-queue, darin, ggaren, j, rniwa, sam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar, WebExposed | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2016-06-09 13:11:19 PDT
Created attachment 280958 [details]
Patch
*** Bug 55663 has been marked as a duplicate of this bug. *** Comment on attachment 280958 [details] Patch Clearing flags on attachment: 280958 Committed r201898: <http://trac.webkit.org/changeset/201898> All reviewed patches have been landed. Closing bug. Comment on attachment 280958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280958&action=review > Source/WebCore/page/Base64Utilities.h:36 > + Base64Utilities() = default; > + We should just delete these two lines of code. This is what a class gets if you don’t explicitly define a constructor. We should do this only if we want to make the default constructor private or protected. Comment on attachment 280958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280958&action=review >> Source/WebCore/page/Base64Utilities.h:36 >> + > > We should just delete these two lines of code. This is what a class gets if you don’t explicitly define a constructor. We should do this only if we want to make the default constructor private or protected. My bad. I'll drop them in a follow up. Comment on attachment 280958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280958&action=review > Source/WebCore/page/Base64Utilities.h:38 > + String btoa(const String& stringToEncode, ExceptionCode&); > + String atob(const String& encodedString, ExceptionCode&); Another thing: These should both be static member functions. More efficient that way. Neither makes any use of "this", directly or indirectly. Committed r201903: <http://trac.webkit.org/changeset/201903> |