Bug 158568

Summary:

WorkerGlobalScope attributes / operations should be on the prototype

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, cdumez, cgarcia, commit-queue, darin, ggaren, sam, webkit-bug-importer

Priority:

Keywords:

InRadar, WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2016-06-09 08:55:45 PDT

WorkerGlobalScope attributes / operations should be on the prototype because WorkerGlobalScope is not marked as [Global] / [PrimaryGlobal]: - https://html.spec.whatwg.org/multipage/workers.html#the-workerglobalscope-common-interface - http://heycam.github.io/webidl/#es-attributes - http://heycam.github.io/webidl/#es-operations DedicatedWorkerGlobalScope is the interface that is marked as [Global] and whose attributes / operations should be on the instance. Test: http://w3c-test.org/workers/interfaces.worker

Attachments
Patch (8.42 KB, patch) 2016-06-09 10:19 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-06-09 09:13:13 PDT

Fixing this bring the number of failures on http://w3c-test.org/workers/interfaces.worker from 65 to 34. It also fixes 1 failure on the corresponding IndexedDB in workers test.

Radar WebKit Bug Importer

Comment 2 2016-06-09 09:18:22 PDT

<rdar://problem/26720079>

Chris Dumez

Comment 3 2016-06-09 10:19:03 PDT

Created attachment 280926 [details] Patch

Geoffrey Garen

Comment 4 2016-06-09 11:44:41 PDT

Comment on attachment 280926 [details] Patch r=me

Chris Dumez

Comment 5 2016-06-09 11:45:51 PDT

Comment on attachment 280926 [details] Patch Clearing flags on attachment: 280926 Committed r201876: <http://trac.webkit.org/changeset/201876>

Chris Dumez

Comment 6 2016-06-09 11:45:57 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.