Bug 158562

Summary: [Threaded Compositor] Make it clear that compositing thread operations are always scheduled from the main thread
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, yoon, zan
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154070    
Attachments:
Description Flags
Patch zan: review+

Description Carlos Garcia Campos 2016-06-09 05:11:52 PDT 
The code is written as if the compositor thread could also call callOnCompositingRunLoop() which makes the code confusing.
Comment 1 Carlos Garcia Campos 2016-06-09 05:18:12 PDT 
Created attachment 280912 [details]
Patch
Comment 2 WebKit Commit Bot 2016-06-09 05:19:01 PDT 
Attachment 280912 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:44:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2016-06-10 05:51:17 PDT 
Committed r201922: <http://trac.webkit.org/changeset/201922>