Bug 158559

Summary: Update properties for UIWKTextInteractionAssistant
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: HTML EditingAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enrica
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2016-06-09 02:27:35 PDT
The UIWKTextInteractionAssistant.loupeGesture and UIWKTextInteractionAssistant.singleTapGesture should be 'assign' instead of 'retain' since UIWKTextInteractionAssistant does not own these properties, so it isn't responsible for releasing them in -dealloc.

This fixed a static analyzer warning on the real class; just mirroring the changes in WebKit2.
Comment 1 David Kilzer (:ddkilzer) 2016-06-09 02:28:43 PDT
<rdar://problem/26669313>
Comment 2 David Kilzer (:ddkilzer) 2016-06-09 02:32:15 PDT
Created attachment 280904 [details]
Patch v1
Comment 3 WebKit Commit Bot 2016-06-09 10:05:36 PDT
Comment on attachment 280904 [details]
Patch v1

Clearing flags on attachment: 280904

Committed r201869: <http://trac.webkit.org/changeset/201869>
Comment 4 WebKit Commit Bot 2016-06-09 10:05:39 PDT
All reviewed patches have been landed.  Closing bug.