Bug 158559

Summary: Update properties for UIWKTextInteractionAssistant
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: HTML EditingAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enrica
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2016-06-09 02:27:35 PDT
The UIWKTextInteractionAssistant.loupeGesture and UIWKTextInteractionAssistant.singleTapGesture should be 'assign' instead of 'retain' since UIWKTextInteractionAssistant does not own these properties, so it isn't responsible for releasing them in -dealloc. This fixed a static analyzer warning on the real class; just mirroring the changes in WebKit2.
Attachments
Patch v1 (1.63 KB, patch)
2016-06-09 02:32 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2016-06-09 02:28:43 PDT
<rdar://problem/26669313>
David Kilzer (:ddkilzer)
Comment 2 2016-06-09 02:32:15 PDT
Created attachment 280904 [details] Patch v1
WebKit Commit Bot
Comment 3 2016-06-09 10:05:36 PDT
Comment on attachment 280904 [details] Patch v1 Clearing flags on attachment: 280904 Committed r201869: <http://trac.webkit.org/changeset/201869>
WebKit Commit Bot
Comment 4 2016-06-09 10:05:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.