Bug 158559 - Update properties for UIWKTextInteractionAssistant
Summary: Update properties for UIWKTextInteractionAssistant
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Keywords: InRadar
Depends on:
Reported: 2016-06-09 02:27 PDT by David Kilzer (:ddkilzer)
Modified: 2016-06-09 10:05 PDT (History)
2 users (show)

See Also:

Patch v1 (1.63 KB, patch)
2016-06-09 02:32 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-06-09 02:27:35 PDT
The UIWKTextInteractionAssistant.loupeGesture and UIWKTextInteractionAssistant.singleTapGesture should be 'assign' instead of 'retain' since UIWKTextInteractionAssistant does not own these properties, so it isn't responsible for releasing them in -dealloc.

This fixed a static analyzer warning on the real class; just mirroring the changes in WebKit2.
Comment 1 David Kilzer (:ddkilzer) 2016-06-09 02:28:43 PDT
Comment 2 David Kilzer (:ddkilzer) 2016-06-09 02:32:15 PDT
Created attachment 280904 [details]
Patch v1
Comment 3 WebKit Commit Bot 2016-06-09 10:05:36 PDT
Comment on attachment 280904 [details]
Patch v1

Clearing flags on attachment: 280904

Committed r201869: <http://trac.webkit.org/changeset/201869>
Comment 4 WebKit Commit Bot 2016-06-09 10:05:39 PDT
All reviewed patches have been landed.  Closing bug.