Bug 158524 – [Win] Shadow DOM tests are failing.

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Per Arne Vollan]

This feature has not been enabled on Windows.

[Per Arne Vollan]

Created attachment 280803 [details]
Patch

[Brent Fulgham]

Comment on attachment 280803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280803&action=review

Looks good! Thanks for getting this working! :-)

> LayoutTests/platform/win/TestExpectations:3361
> +webkit.org/b/148695 fast/shadow-dom [ Pass ]

Why is this necessary if they are all passes? Can't this line just be removed? Or will the tests not run (because a parent 'TestExpectations' file has them turned off?

[Per Arne Vollan]

(In reply to comment #2)
> Comment on attachment 280803 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280803&action=review
> 
> Looks good! Thanks for getting this working! :-)
> 
> > LayoutTests/platform/win/TestExpectations:3361
> > +webkit.org/b/148695 fast/shadow-dom [ Pass ]
> 
> Why is this necessary if they are all passes? Can't this line just be
> removed? Or will the tests not run (because a parent 'TestExpectations' file
> has them turned off?

Yes, this will override the expectations from the top level 'TextExpectations' file. It is copied from the Mac test expectations.

Thanks for reviewing!

[Per Arne Vollan]

Committed r201817: <http://trac.webkit.org/changeset/201817>