| Summary: | [Win] Shadow DOM tests are failing. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
| Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, bfulgham | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Per Arne Vollan
2016-06-08 06:47:19 PDT
Created attachment 280803 [details]
Patch
Comment on attachment 280803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280803&action=review Looks good! Thanks for getting this working! :-) > LayoutTests/platform/win/TestExpectations:3361 > +webkit.org/b/148695 fast/shadow-dom [ Pass ] Why is this necessary if they are all passes? Can't this line just be removed? Or will the tests not run (because a parent 'TestExpectations' file has them turned off? (In reply to comment #2) > Comment on attachment 280803 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280803&action=review > > Looks good! Thanks for getting this working! :-) > > > LayoutTests/platform/win/TestExpectations:3361 > > +webkit.org/b/148695 fast/shadow-dom [ Pass ] > > Why is this necessary if they are all passes? Can't this line just be > removed? Or will the tests not run (because a parent 'TestExpectations' file > has them turned off? Yes, this will override the expectations from the top level 'TextExpectations' file. It is copied from the Mac test expectations. Thanks for reviewing! Committed r201817: <http://trac.webkit.org/changeset/201817> |