Bug 158523

Summary: [Threaded Compositor] Remove ThreadedCompositor::setNeedsDisplay()
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, yoon, zan
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2016-06-08 06:46:06 PDT
ThreadedCompositor::setNeedsDisplay() is always called from the main thread and schedules a task to the compositing thread to schedule an immediate update. But RunLoop::Timer is thread-safe so we don't really need to schedule a task to the update the timer in the compositing thread, we can do that directly in the main thread. And that's exactly what scheduleDisplayImmediately() do, so we can use that instead of setNeedsDisplay().
Attachments
Patch (3.08 KB, patch)
2016-06-08 06:49 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-06-08 06:49:11 PDT
Created attachment 280802 [details] Patch
Carlos Garcia Campos
Comment 2 2016-06-09 05:06:18 PDT
Committed r201859: <http://trac.webkit.org/changeset/201859>
Note You need to log in before you can comment on or make changes to this bug.