Bug 158523 - [Threaded Compositor] Remove ThreadedCompositor::setNeedsDisplay()
Summary: [Threaded Compositor] Remove ThreadedCompositor::setNeedsDisplay()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-06-08 06:46 PDT by Carlos Garcia Campos
Modified: 2016-06-09 05:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.08 KB, patch)
2016-06-08 06:49 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-06-08 06:46:06 PDT 
ThreadedCompositor::setNeedsDisplay() is always called from the main thread and schedules a task to the compositing thread to schedule an immediate update. But RunLoop::Timer is thread-safe so we don't really need to schedule a task to the update the timer in the compositing thread, we can do that directly in the main thread. And that's exactly what scheduleDisplayImmediately() do, so we can use that instead of setNeedsDisplay().
Comment 1 Carlos Garcia Campos 2016-06-08 06:49:11 PDT 
Created attachment 280802 [details]
Patch
Comment 2 Carlos Garcia Campos 2016-06-09 05:06:18 PDT 
Committed r201859: <http://trac.webkit.org/changeset/201859>