Bug 158515
| Summary: | [EFL] Build fix related with SharedBuffer::createFromReadingFile in SharedBufferPosix.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joonghun Park <jh718.park> |
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Joonghun Park
This patch fixes the build error shown as below.
../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp: In static member function ‘static WTF::RefPtr<WebCore::SharedBuffer> WebCore::SharedBuffer::createFromReadingFile(const WTF::String&)’:
../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:69:42: error: operands to ?: have different types ‘WTF::Ref<WebCore::SharedBuffer>’ and ‘int’
return totalBytesRead == bytesToRead ? SharedBuffer::adoptVector(buffer) : 0;
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Joonghun Park
Committed r201790: <http://trac.webkit.org/changeset/201790>
Gyuyoung Kim
(In reply to comment #1)
> Committed r201790: <http://trac.webkit.org/changeset/201790>
Personally I prefer to fix this issue as https://bugs.webkit.org/attachment.cgi?id=280763&action=review
Joonghun Park
(In reply to comment #2)
> (In reply to comment #1)
> > Committed r201790: <http://trac.webkit.org/changeset/201790>
>
> Personally I prefer to fix this issue as
> https://bugs.webkit.org/attachment.cgi?id=280763&action=review
I realized that I missed to change 0s to nullptr when I saw the https://bugs.webkit.org/attachment.cgi?id=280763. That would be more proper one.