Bug 158493

Summary:

Add result validation to JSAir

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Tools / Tests

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, cdumez, commit-queue, ggaren, keith_miller, lforschler, mark.lam, mhahnenb, msaboff, oliver, rniwa, saam, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=158571

Bug Depends on:

Bug Blocks:

158492

Attachments:

Description	Flags
almost done	none
the patch	none
smaller patch	none
even smaller patch	none
even smaller patch	none
so small patch	saam: review+

Description Filip Pizlo 2016-06-07 13:59:42 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2016-06-07 22:02:51 PDT

Created attachment 280767 [details]
almost done

Comment 2 Filip Pizlo 2016-06-07 22:03:05 PDT

I found some excellent bugs while doing this.

Comment 3 Filip Pizlo 2016-06-07 23:59:35 PDT

Created attachment 280780 [details]
the patch

Comment 4 Filip Pizlo 2016-06-08 00:01:26 PDT

Created attachment 280781 [details]
smaller patch

Comment 5 Filip Pizlo 2016-06-08 00:03:10 PDT

Created attachment 280782 [details]
even smaller patch

Comment 6 Filip Pizlo 2016-06-08 00:18:34 PDT

Created attachment 280785 [details]
even smaller patch

Comment 7 Filip Pizlo 2016-06-08 00:19:44 PDT

Created attachment 280786 [details]
so small patch

Comment 8 Saam Barati 2016-06-08 00:46:00 PDT

Comment on attachment 280786 [details]
so small patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280786&action=review

> PerformanceTests/JSAir/benchmark.js:64
> +                throw new Error("Wrong early hash for " + payload.generate.name +": " + hash);

s/early/late

Comment 9 Filip Pizlo 2016-06-08 10:20:49 PDT

Landed in http://trac.webkit.org/changeset/201807