Bug 158493

Summary: Add result validation to JSAir
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cdumez, commit-queue, ggaren, keith_miller, lforschler, mark.lam, mhahnenb, msaboff, oliver, rniwa, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=158571
Bug Depends on:    
Bug Blocks: 158492    
Attachments:
Description Flags
almost done
none
the patch
none
smaller patch
none
even smaller patch
none
even smaller patch
none
so small patch saam: review+

Filip Pizlo
Reported 2016-06-07 13:59:42 PDT
Patch forthcoming.
Attachments
almost done (320.81 KB, patch)
2016-06-07 22:02 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (616.32 KB, patch)
2016-06-07 23:59 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
smaller patch (548.17 KB, patch)
2016-06-08 00:01 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
even smaller patch (345.37 KB, patch)
2016-06-08 00:03 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
even smaller patch (218.46 KB, patch)
2016-06-08 00:18 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
so small patch (111.34 KB, patch)
2016-06-08 00:19 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-06-07 22:02:51 PDT
Created attachment 280767 [details] almost done
Filip Pizlo
Comment 2 2016-06-07 22:03:05 PDT
I found some excellent bugs while doing this.
Filip Pizlo
Comment 3 2016-06-07 23:59:35 PDT
Created attachment 280780 [details] the patch
Filip Pizlo
Comment 4 2016-06-08 00:01:26 PDT
Created attachment 280781 [details] smaller patch
Filip Pizlo
Comment 5 2016-06-08 00:03:10 PDT
Created attachment 280782 [details] even smaller patch
Filip Pizlo
Comment 6 2016-06-08 00:18:34 PDT
Created attachment 280785 [details] even smaller patch
Filip Pizlo
Comment 7 2016-06-08 00:19:44 PDT
Created attachment 280786 [details] so small patch
Saam Barati
Comment 8 2016-06-08 00:46:00 PDT
Comment on attachment 280786 [details] so small patch View in context: https://bugs.webkit.org/attachment.cgi?id=280786&action=review > PerformanceTests/JSAir/benchmark.js:64 > + throw new Error("Wrong early hash for " + payload.generate.name +": " + hash); s/early/late
Filip Pizlo
Comment 9 2016-06-08 10:20:49 PDT
Landed in http://trac.webkit.org/changeset/201807
Note You need to log in before you can comment on or make changes to this bug.