Bug 158487

Summary: AX: iOS: Need to expose whether object is a dialog element
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

chris fleizach
Reported 2016-06-07 11:37:19 PDT
We need to expose whether an element is a dialog element to higher level code to determine VoiceOver behavior on iOS
Attachments
Patch (1.52 KB, patch)
2016-06-07 11:39 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2016-06-07 12:25 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2016-06-07 11:37:32 PDT
<rdar://problem/26678218>
chris fleizach
Comment 2 2016-06-07 11:39:28 PDT
Created attachment 280726 [details] Patch
Joanmarie Diggs
Comment 3 2016-06-07 11:56:04 PDT
Layout test? Nit: Re-read your ChangeLog statement (in particular the commas and position of "so" cannot all be what you want)
chris fleizach
Comment 4 2016-06-07 12:25:57 PDT
Created attachment 280732 [details] Patch
chris fleizach
Comment 5 2016-06-07 12:26:06 PDT
(In reply to comment #3) > Layout test? > > Nit: Re-read your ChangeLog statement (in particular the commas and position > of "so" cannot all be what you want) Updated
Joanmarie Diggs
Comment 6 2016-06-07 13:28:47 PDT
(In reply to comment #5) > (In reply to comment #3) > > Layout test? > > > > Nit: Re-read your ChangeLog statement (in particular the commas and position > > of "so" cannot all be what you want) > > Updated But still no layout test?
chris fleizach
Comment 7 2016-06-07 13:47:12 PDT
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #3) > > > Layout test? > > > > > > Nit: Re-read your ChangeLog statement (in particular the commas and position > > > of "so" cannot all be what you want) > > > > Updated > > But still no layout test? There's nothing to test at this level of WebCore.
Joanmarie Diggs
Comment 8 2016-06-07 15:16:03 PDT
Comment on attachment 280732 [details] Patch (In reply to comment #7) > There's nothing to test at this level of WebCore. With respect to VoiceOver, sure. I would have thought that the attribute being exposed here to address the VO issue would warrant a test. But ok.
chris fleizach
Comment 9 2016-06-07 15:21:24 PDT
(In reply to comment #8) > Comment on attachment 280732 [details] > Patch > > (In reply to comment #7) > > > There's nothing to test at this level of WebCore. > > With respect to VoiceOver, sure. I would have thought that the attribute > being exposed here to address the VO issue would warrant a test. But ok. That logic can't be tested at this level. Needs to be higher up
WebKit Commit Bot
Comment 10 2016-06-07 15:44:26 PDT
Comment on attachment 280732 [details] Patch Clearing flags on attachment: 280732 Committed r201774: <http://trac.webkit.org/changeset/201774>
WebKit Commit Bot
Comment 11 2016-06-07 15:44:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.