| Summary: | The backdrop-filter property does not respect border-radius | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Antoine Quint <graouts> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | asa_carter, commit-queue, graouts, ryanhaddad, simon.fraser, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Antoine Quint
2016-06-07 10:31:00 PDT
Created attachment 280720 [details]
Testcase
Created attachment 280747 [details]
Patch
Comment on attachment 280747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280747&action=review Code looks good but please use ref tests. > Source/WebCore/platform/graphics/GraphicsLayer.h:381 > + FloatRoundedRect backdropFiltersRect() const { return m_backdropFiltersRect; } Return a const ref. These things are big. Created attachment 280752 [details]
Patch
Comment on attachment 280752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280752&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:435 > + LayoutRect boxRect = renderer.borderBoxRect(); Odd to fetch boxRect again, and alias the variable. Better to use renderer().style().hasBorderRadius() > LayoutTests/css3/filters/backdrop/backdrop-filter-with-border-radius-and-reflection-expected.html:2 > + <meta name="viewport" content="width=device-width"> Pretty sure this does nothing in tests (unless you opt in to viewport stuff). Created attachment 280759 [details]
Patch for landing
Comment on attachment 280759 [details] Patch for landing Clearing flags on attachment: 280759 Committed r201785: <http://trac.webkit.org/changeset/201785> All reviewed patches have been landed. Closing bug. This change appears to have caused LayoutTest css3/filters/backdrop/dynamic-backdrop-filter-change.html to become much more flaky on Mac http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=css3%2Ffilters%2Fbackdrop%2Fdynamic-backdrop-filter-change.html *** Bug 158807 has been marked as a duplicate of this bug. *** |