Bug 158478

Summary:

[WebVTT] change "middle" to "center" for consistency with CSS

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, eric.carlson, ews-watchlist, pvollan, rniwa, webkit-bug-importer, zcorpan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews113 for mac-sierra	none
Patch	none

Eric Carlson

Reported 2016-06-07 07:19:20 PDT

The WebVTT spec is changing align from 'middle' to 'center' to match CSS [1]. According to Simon's analysis this change should not cause serious compatibility problems [2]. [1] https://github.com/w3c/webvtt/pull/244 [2] https://github.com/w3c/webvtt/issues/301#issuecomment-224235961

Attachments
Patch (30.76 KB, patch) 2018-09-17 15:58 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.50 MB, application/zip) 2018-09-17 17:11 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.39 MB, application/zip) 2018-09-17 17:43 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.21 MB, application/zip) 2018-09-17 18:06 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-sierra (3.00 MB, application/zip) 2018-09-17 18:12 PDT, EWS Watchlist	no flags	Details
Patch (30.75 KB, patch) 2018-09-18 07:12 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-06-07 07:20:45 PDT

<rdar://problem/26672692>

Simon Pieters (:zcorpan)

Comment 2 2017-02-22 01:48:04 PST

This is now fixed in Gecko (don't know bug #) and Chromium https://bugs.chromium.org/p/chromium/issues/detail?id=663797 web-platform-tests expect "center".

Simon Pieters (:zcorpan)

Comment 3 2017-02-22 02:01:11 PST

e.g. http://w3c-test.org/webvtt/api/VTTCue/align.html

Per Arne Vollan

Comment 4 2018-09-17 15:58:41 PDT

Created attachment 349961 [details] Patch

EWS Watchlist

Comment 5 2018-09-17 17:11:12 PDT

Comment on attachment 349961 [details] Patch Attachment 349961 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9249797 New failing tests: media/track/track-webvtt-tc021-valign.html

EWS Watchlist

Comment 6 2018-09-17 17:11:14 PDT

Created attachment 349976 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-09-17 17:43:41 PDT

Comment on attachment 349961 [details] Patch Attachment 349961 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9249799 New failing tests: media/track/track-webvtt-tc021-valign.html

EWS Watchlist

Comment 8 2018-09-17 17:43:42 PDT

Created attachment 349981 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 9 2018-09-17 18:06:35 PDT

Comment on attachment 349961 [details] Patch Attachment 349961 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9250443 New failing tests: media/track/track-webvtt-tc021-valign.html

EWS Watchlist

Comment 10 2018-09-17 18:06:37 PDT

Created attachment 349983 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 11 2018-09-17 18:12:50 PDT

Comment on attachment 349961 [details] Patch Attachment 349961 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9250216 New failing tests: media/track/track-webvtt-tc021-valign.html

EWS Watchlist

Comment 12 2018-09-17 18:12:52 PDT

Created attachment 349984 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6

Eric Carlson

Comment 13 2018-09-18 06:08:24 PDT

Comment on attachment 349961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349961&action=review > LayoutTests/media/track/track-webvtt-tc021-valign.html:36 > - values : ["middle", "middle", "start"], > + values : ["center", "center", "center"], Nit: did you mean to change "start" to "center"?

Per Arne Vollan

Comment 14 2018-09-18 07:12:27 PDT

Created attachment 350019 [details] Patch

Eric Carlson

Comment 15 2018-09-18 07:21:13 PDT

Comment on attachment 350019 [details] Patch r=me once the bots are happy.

Per Arne Vollan

Comment 16 2018-09-18 08:39:33 PDT

Comment on attachment 350019 [details] Patch Thanks for reviewing!

WebKit Commit Bot

Comment 17 2018-09-18 09:07:31 PDT

Comment on attachment 350019 [details] Patch Clearing flags on attachment: 350019 Committed r236143: <https://trac.webkit.org/changeset/236143>

WebKit Commit Bot

Comment 18 2018-09-18 09:07:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.