Bug 158418

Summary: [EFL] Move efl include paths to JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2016-06-06 05:59:03 PDT
In Source/JavaScriptCore/PlatformEfl.cmake, we don't use JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES for efl include paths. Let's use it.
Attachments
Patch (1.51 KB, patch)
2016-06-06 05:59 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2016-06-06 05:59:56 PDT
Created attachment 280592 [details] Patch
Csaba Osztrogonác
Comment 2 2016-06-06 06:48:14 PDT
Is JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES to avoid possible warnings in third party header files?
Gyuyoung Kim
Comment 3 2016-06-06 06:54:57 PDT
(In reply to comment #2) > Is JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES to avoid > possible warnings in third party header files? Yes, right. FYI - https://trac.webkit.org/changeset/185806
Csaba Osztrogonác
Comment 4 2016-06-06 07:06:35 PDT
Comment on attachment 280592 [details] Patch OK, r=me.
WebKit Commit Bot
Comment 5 2016-06-06 07:29:54 PDT
Comment on attachment 280592 [details] Patch Clearing flags on attachment: 280592 Committed r201711: <http://trac.webkit.org/changeset/201711>
WebKit Commit Bot
Comment 6 2016-06-06 07:29:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.