Summary: | [EFL] Sync EFL features with featureList.pm | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, lucas.de.marchi, tonikitoo | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2016-06-05 20:40:45 PDT
Created attachment 280575 [details]
Patch
Created attachment 280576 [details]
Patch
Comment on attachment 280576 [details]
Patch
r=me.
Could you confirm to me if this actually changes the status of these features in regular builds?
(In reply to comment #3) > Comment on attachment 280576 [details] > Patch > > r=me. > > Could you confirm to me if this actually changes the status of these > features in regular builds? As far as I know the feature definitions of OptionEfl.cmake is just being used to add the feature name to *cmakeconfig.h* (Auto-generated cmakeconfig.h actually defines on/off status). Actual on/off status of cmakeconfig.h is done by FeatureList.pm on EFL port. So now I don't know whether we should keep on/off status in OptionEfl.cmake because it work nothing unless we build EFL port using cmake directly, not use *Tools/Scripts/build-webkit* script. If we don't need to keep the on/off status in OptionsEfl.cmake, I will try to remove it. But it seems to me that it would be good to sync with the status between OptionEfl.cmake and FeatureList.pm at the moment. Comment on attachment 280576 [details] Patch Clearing flags on attachment: 280576 Committed r201707: <http://trac.webkit.org/changeset/201707> All reviewed patches have been landed. Closing bug. |