Bug 158394
| Summary: | Fix the build after r201693 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | New Bugs | Assignee: | Brady Eidson <beidson> |
| Status: | RESOLVED FIXED | ||
| Severity: | Blocker | CC: | beidson, darin |
| Priority: | P1 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Csaba Osztrogonác
https://trac.webkit.org/changeset/201693 broke the build everywhere, see build.webkit.org for details and fix it ASAP.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brady Eidson
This is one of the rare cases I wish somebody had jumped to rolling out, as it is unlikely I would've been paying attention at 12:30AM!
I had uncommitted changes in my Source/WebKit2, and since I couldn't use EWS/commit bot I didn't notice the patch was incomplete.
Working on it now.
Brady Eidson
http://trac.webkit.org/changeset/201694
Brady Eidson
Apparently that didn't fix it because of some linker error that I am not seeing locally.
Great!
I'll just roll these out for now, as I'm out of early morning time to try to fix.
Brady Eidson
Reverted r201694 for reason:
201693
Committed r201695: <http://trac.webkit.org/changeset/201695>
Brady Eidson
Still a weird linker error on the bots (built fine locally...)
Rolled out for now, and will resolve in the original bug later.