Bug 158394 - Fix the build after r201693
Summary: Fix the build after r201693
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-05 00:34 PDT by Csaba Osztrogonác
Modified: 2016-06-05 07:53 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-06-05 00:34:56 PDT 
https://trac.webkit.org/changeset/201693 broke the build everywhere, see build.webkit.org for details and fix it ASAP.
Comment 1 Brady Eidson 2016-06-05 07:30:33 PDT 
This is one of the rare cases I wish somebody had jumped to rolling out, as it is unlikely I would've been paying attention at 12:30AM!

I had uncommitted changes in my Source/WebKit2, and since I couldn't use EWS/commit bot I didn't notice the patch was incomplete.

Working on it now.
Comment 2 Brady Eidson 2016-06-05 07:44:44 PDT 
http://trac.webkit.org/changeset/201694
Comment 3 Brady Eidson 2016-06-05 07:50:42 PDT 
Apparently that didn't fix it because of some linker error that I am not seeing locally.

Great!

I'll just roll these out for now, as I'm out of early morning time to try to fix.
Comment 4 Brady Eidson 2016-06-05 07:52:08 PDT 
Reverted r201694 for reason:

201693

Committed r201695: <http://trac.webkit.org/changeset/201695>
Comment 5 Brady Eidson 2016-06-05 07:53:58 PDT 
Still a weird linker error on the bots (built fine locally...)

Rolled out for now, and will resolve in the original bug later.