Bug 158377

Summary: REGRESSION (r201474): Should set overflow: hidden on -webkit-media-controls when placeholder is showing
Product: WebKit Reporter: Ada Chan <adachan>
Component: MediaAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Ada Chan
Reported 2016-06-03 20:30:08 PDT
We added script to specify overflow: hidden on -webkit-media-controls when the placeholder is showing in r201355 but that code needs to update after r201474. After r201474, we defer removing the hidden class from inlinePlaybackPlaceholder until showInlinePlaybackPlaceholderWhenSafe(). We also need to move the code that adds the placeholder-showing class to -webkit-media-controls to that method. <rdar://problem/26633830>
Attachments
Patch (3.24 KB, patch)
2016-06-03 21:38 PDT, Ada Chan 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2016-06-03 21:38:18 PDT
Created attachment 280508 [details] Patch
Ada Chan
Comment 2 2016-06-04 17:36:28 PDT
Committed: http://trac.webkit.org/changeset/201691
Note You need to log in before you can comment on or make changes to this bug.