Bug 158353

Summary: Miscellaneous IDBBindingUtilities cleanup
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch thorton: review+

Description Brady Eidson 2016-06-03 13:40:43 PDT
Miscellaneous IDBBindingUtilities cleanup
Comment 1 Brady Eidson 2016-06-03 13:51:23 PDT
Created attachment 280460 [details]
Patch
Comment 2 Tim Horton 2016-06-03 14:29:54 PDT
Comment on attachment 280460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280460&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (Straight refactor, yo).

Can't you test the new errors?
Comment 3 Brady Eidson 2016-06-03 14:39:14 PDT
(In reply to comment #2)
> Comment on attachment 280460 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280460&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests (Straight refactor, yo).
> 
> Can't you test the new errors?

Sadly, no.

We know "ScriptExecutionContext without an ExecState" is a possibility, somehow, but it's not known to be purposefully triggerable...

If I'm wrong and somebody lets me know, I'd happily add tests.
Comment 4 Brady Eidson 2016-06-03 14:41:09 PDT
http://trac.webkit.org/changeset/201660