Bug 158326

Summary: Rename CheckedRadioButtons into RadioButtonGroups
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Benjamin Poulain
Reported 2016-06-02 16:12:55 PDT
Rename CheckedRadioButtons into RadioButtonGroups
Attachments
Patch (41.01 KB, patch)
2016-06-02 16:17 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (41.80 KB, patch)
2016-06-02 17:43 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch for landing (41.73 KB, patch)
2016-06-03 14:12 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-06-02 16:17:08 PDT
Created attachment 280381 [details] Patch
Benjamin Poulain
Comment 2 2016-06-02 17:43:39 PDT
Created attachment 280392 [details] Patch
Alex Christensen
Comment 3 2016-06-03 09:13:12 PDT
Comment on attachment 280392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280392&action=review > Source/WebCore/dom/RadioButtonGroups.h:22 > +#ifndef RadioButtonGroups_h > +#define RadioButtonGroups_h #pragma once
Saam Barati
Comment 4 2016-06-03 09:56:40 PDT
(In reply to comment #3) > Comment on attachment 280392 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280392&action=review > > > Source/WebCore/dom/RadioButtonGroups.h:22 > > +#ifndef RadioButtonGroups_h > > +#define RadioButtonGroups_h > > #pragma once I thought we were running into issues with #pragma once Am I mistaken or did we fix them somehow?
Benjamin Poulain
Comment 5 2016-06-03 14:12:47 PDT
Created attachment 280462 [details] Patch for landing
WebKit Commit Bot
Comment 6 2016-06-03 14:35:30 PDT
Comment on attachment 280462 [details] Patch for landing Clearing flags on attachment: 280462 Committed r201659: <http://trac.webkit.org/changeset/201659>
WebKit Commit Bot
Comment 7 2016-06-03 14:35:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.