Bug 158326 - Rename CheckedRadioButtons into RadioButtonGroups
Summary: Rename CheckedRadioButtons into RadioButtonGroups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-02 16:12 PDT by Benjamin Poulain
Modified: 2016-06-03 14:35 PDT (History)
2 users (show)

See Also:


Attachments
Patch (41.01 KB, patch)
2016-06-02 16:17 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (41.80 KB, patch)
2016-06-02 17:43 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch for landing (41.73 KB, patch)
2016-06-03 14:12 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-06-02 16:12:55 PDT
Rename CheckedRadioButtons into RadioButtonGroups
Comment 1 Benjamin Poulain 2016-06-02 16:17:08 PDT
Created attachment 280381 [details]
Patch
Comment 2 Benjamin Poulain 2016-06-02 17:43:39 PDT
Created attachment 280392 [details]
Patch
Comment 3 Alex Christensen 2016-06-03 09:13:12 PDT
Comment on attachment 280392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280392&action=review

> Source/WebCore/dom/RadioButtonGroups.h:22
> +#ifndef RadioButtonGroups_h
> +#define RadioButtonGroups_h

#pragma once
Comment 4 Saam Barati 2016-06-03 09:56:40 PDT
(In reply to comment #3)
> Comment on attachment 280392 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280392&action=review
> 
> > Source/WebCore/dom/RadioButtonGroups.h:22
> > +#ifndef RadioButtonGroups_h
> > +#define RadioButtonGroups_h
> 
> #pragma once

I thought we were running into issues with #pragma once
Am I mistaken or did we fix them somehow?
Comment 5 Benjamin Poulain 2016-06-03 14:12:47 PDT
Created attachment 280462 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2016-06-03 14:35:30 PDT
Comment on attachment 280462 [details]
Patch for landing

Clearing flags on attachment: 280462

Committed r201659: <http://trac.webkit.org/changeset/201659>
Comment 7 WebKit Commit Bot 2016-06-03 14:35:34 PDT
All reviewed patches have been landed.  Closing bug.