Summary: | [MSE] Adopt +[AVStreamDataParser outputMIMECodecParameterForInputMIMECodecParameter:] | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | james.east, jonlee, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Jer Noble
2016-06-02 12:58:39 PDT
Created attachment 280618 [details]
Patch
Comment on attachment 280618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280618&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:129 > +@interface AVStreamDataParser : NSObject > ++ (NSString *)outputMIMECodecParameterForInputMIMECodecParameter:(NSString *)inputMIMECodecParameter; > +@end We normally put these in SPI.h headers, not inside implementation files. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:270 > + NSString *typeString = [NSString stringWithFormat:@"%@; codecs=\"%@\"", (NSString *)parameters.type, (NSString *)outputCodecs]; No reason for the (NSString *) cast on outputCodecs any more. (In reply to comment #3) > Comment on attachment 280618 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280618&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:129 > > +@interface AVStreamDataParser : NSObject > > ++ (NSString *)outputMIMECodecParameterForInputMIMECodecParameter:(NSString *)inputMIMECodecParameter; > > +@end > > We normally put these in SPI.h headers, not inside implementation files. > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:270 > > + NSString *typeString = [NSString stringWithFormat:@"%@; codecs=\"%@\"", (NSString *)parameters.type, (NSString *)outputCodecs]; > > No reason for the (NSString *) cast on outputCodecs any more. No, I think that for variable-length argument lists, the NSString* casts are really necessary. Created attachment 281849 [details]
Patch
Comment on attachment 281849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281849&action=review > Source/WebCore/ChangeLog:5 > + Radar url? Created attachment 281960 [details]
Patch for landing
Created attachment 281987 [details]
Patch for landing
Created attachment 281996 [details]
Patch for landing
Committed r202429: <http://trac.webkit.org/changeset/202429> |