Bug 158312

Summary: [MSE] Adopt +[AVStreamDataParser outputMIMECodecParameterForInputMIMECodecParameter:]
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: james.east, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
eric.carlson: review+
Patch for landing
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2016-06-02 12:58:39 PDT
[MSE] Adopt +[AVStreamDataParser outputMIMECodecParameterForInputMIMECodecParameter:]
Attachments
Patch (2.54 KB, patch)
2016-06-06 12:37 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (10.46 KB, patch)
2016-06-22 10:21 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (10.62 KB, patch)
2016-06-23 23:33 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.15 KB, patch)
2016-06-24 09:41 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.20 KB, patch)
2016-06-24 10:15 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-06-03 09:45:43 PDT
rdar://problem/26258555
Jer Noble
Comment 2 2016-06-06 12:37:51 PDT
Created attachment 280618 [details] Patch
Darin Adler
Comment 3 2016-06-06 18:27:14 PDT
Comment on attachment 280618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280618&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:129 > +@interface AVStreamDataParser : NSObject > ++ (NSString *)outputMIMECodecParameterForInputMIMECodecParameter:(NSString *)inputMIMECodecParameter; > +@end We normally put these in SPI.h headers, not inside implementation files. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:270 > + NSString *typeString = [NSString stringWithFormat:@"%@; codecs=\"%@\"", (NSString *)parameters.type, (NSString *)outputCodecs]; No reason for the (NSString *) cast on outputCodecs any more.
Jer Noble
Comment 4 2016-06-09 13:47:13 PDT
(In reply to comment #3) > Comment on attachment 280618 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280618&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:129 > > +@interface AVStreamDataParser : NSObject > > ++ (NSString *)outputMIMECodecParameterForInputMIMECodecParameter:(NSString *)inputMIMECodecParameter; > > +@end > > We normally put these in SPI.h headers, not inside implementation files. > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:270 > > + NSString *typeString = [NSString stringWithFormat:@"%@; codecs=\"%@\"", (NSString *)parameters.type, (NSString *)outputCodecs]; > > No reason for the (NSString *) cast on outputCodecs any more. No, I think that for variable-length argument lists, the NSString* casts are really necessary.
Jer Noble
Comment 5 2016-06-22 10:21:17 PDT
Created attachment 281849 [details] Patch
Eric Carlson
Comment 6 2016-06-22 10:25:08 PDT
Comment on attachment 281849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281849&action=review > Source/WebCore/ChangeLog:5 > + Radar url?
Jer Noble
Comment 7 2016-06-23 23:33:43 PDT
Created attachment 281960 [details] Patch for landing
Jer Noble
Comment 8 2016-06-24 09:41:45 PDT
Created attachment 281987 [details] Patch for landing
Jer Noble
Comment 9 2016-06-24 10:15:05 PDT
Created attachment 281996 [details] Patch for landing
Jer Noble
Comment 10 2016-06-24 10:46:36 PDT
Committed r202429: <http://trac.webkit.org/changeset/202429>
Note You need to log in before you can comment on or make changes to this bug.