Bug 158306

Summary: Make it easier to use NoLockingNecessary
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Web Template FrameworkAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch keith_miller: review+

Filip Pizlo
Reported 2016-06-02 11:09:41 PDT
Patch forthcoming.
Attachments
the patch (23.83 KB, patch)
2016-06-02 11:18 PDT, Filip Pizlo 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-06-02 11:18:51 PDT
Created attachment 280342 [details] the patch
WebKit Commit Bot
Comment 2 2016-06-02 11:21:29 PDT
Attachment 280342 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Locker.h:48: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 3 2016-06-02 11:37:37 PDT
Comment on attachment 280342 [details] the patch r=me. Although, the implicit cast nature of the NoLockingNecessaryTag still terrifies me. I dread the day I see Locker(someIntegralVariableWithANameThatLooksTooCloseToALock)
Filip Pizlo
Comment 4 2016-06-02 11:40:10 PDT
Landed in http://trac.webkit.org/changeset/201605
Filip Pizlo
Comment 5 2016-06-02 11:40:31 PDT
(In reply to comment #3) > Comment on attachment 280342 [details] > the patch > > r=me. Although, the implicit cast nature of the NoLockingNecessaryTag still > terrifies me. I dread the day I see > Locker(someIntegralVariableWithANameThatLooksTooCloseToALock) Maybe we can solve that by having an overload of Locker that takes int and asserts?
Keith Miller
Comment 6 2016-06-02 11:46:31 PDT
> Maybe we can solve that by having an overload of Locker that takes int and > asserts? That seems like a good idea. rs=me.
Filip Pizlo
Comment 7 2016-06-02 12:20:50 PDT
(In reply to comment #6) > > Maybe we can solve that by having an overload of Locker that takes int and > > asserts? > > That seems like a good idea. rs=me. Landed in http://trac.webkit.org/changeset/201609
Alexey Proskuryakov
Comment 8 2016-06-02 12:23:29 PDT
Can it just be an overload with "= delete"?
Filip Pizlo
Comment 9 2016-06-02 12:24:58 PDT
(In reply to comment #8) > Can it just be an overload with "= delete"? Aw snap! I'll do that.
Filip Pizlo
Comment 10 2016-06-02 12:25:13 PDT
(In reply to comment #9) > (In reply to comment #8) > > Can it just be an overload with "= delete"? > > Aw snap! I'll do that. RS to do this or do you want to see the patch?
Filip Pizlo
Comment 11 2016-06-02 12:39:16 PDT
(In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > Can it just be an overload with "= delete"? > > > > Aw snap! I'll do that. > > RS to do this or do you want to see the patch? Saam rubber stamped this in person. Landed here: http://trac.webkit.org/changeset/201611
Note You need to log in before you can comment on or make changes to this bug.