|Summary:||[GTK] Update YouCompleteMe script to make all include paths absolute|
|Product:||WebKit||Reporter:||youenn fablet <youennf>|
|Component:||WebKitGTK||Assignee:||youenn fablet <youennf>|
|Severity:||Normal||CC:||bugs-noreply, changseok, commit-queue, mcatanzaro, mrobinson|
|Version:||WebKit Nightly Build|
Description youenn fablet 2016-06-02 03:41:29 PDT
YCM does not make all include paths absolute. At least on my setup, dependencies headers are not always found.
Comment 2 Michael Catanzaro 2016-06-02 06:25:28 PDT
What is this script?
Comment 3 youenn fablet 2016-06-02 06:30:11 PDT
(In reply to comment #2) > What is this script? It allows https://github.com/Valloric/YouCompleteMe working properly for WebKit source base.
Comment 4 Michael Catanzaro 2016-06-02 06:38:37 PDT
Comment on attachment 280328 [details] Patch OK, rubber stamp, but please separately add a comment to the top of this script to indicate what it's for.
Comment 5 youenn fablet 2016-06-02 06:56:39 PDT
(In reply to comment #4) > Comment on attachment 280328 [details] > Patch > > OK, rubber stamp, but please separately add a comment to the top of this > script to indicate what it's for. OK, thanks, I'll clarify the changelog. Martin, changseok, would you be able to check that the change is not disrupting your setup?
Comment 6 youenn fablet 2016-06-03 08:09:33 PDT
Created attachment 280444 [details] Patch for landing
Comment 7 WebKit Commit Bot 2016-06-03 08:39:18 PDT
Comment on attachment 280444 [details] Patch for landing Clearing flags on attachment: 280444 Committed r201642: <http://trac.webkit.org/changeset/201642>
Comment 8 WebKit Commit Bot 2016-06-03 08:39:24 PDT
All reviewed patches have been landed. Closing bug.