Bug 158301

Summary: [GTK] Update YouCompleteMe script to make all include paths absolute
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebKitGTKAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, changseok, commit-queue, mcatanzaro, mrobinson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2016-06-02 03:41:29 PDT
YCM does not make all include paths absolute. At least on my setup, dependencies headers are not always found.
Attachments
Patch (1.34 KB, patch)
2016-06-02 03:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.51 KB, patch)
2016-06-03 08:09 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-06-02 03:43:54 PDT
Created attachment 280328 [details] Patch
Michael Catanzaro
Comment 2 2016-06-02 06:25:28 PDT
What is this script?
youenn fablet
Comment 3 2016-06-02 06:30:11 PDT
(In reply to comment #2) > What is this script? It allows https://github.com/Valloric/YouCompleteMe working properly for WebKit source base.
Michael Catanzaro
Comment 4 2016-06-02 06:38:37 PDT
Comment on attachment 280328 [details] Patch OK, rubber stamp, but please separately add a comment to the top of this script to indicate what it's for.
youenn fablet
Comment 5 2016-06-02 06:56:39 PDT
(In reply to comment #4) > Comment on attachment 280328 [details] > Patch > > OK, rubber stamp, but please separately add a comment to the top of this > script to indicate what it's for. OK, thanks, I'll clarify the changelog. Martin, changseok, would you be able to check that the change is not disrupting your setup?
youenn fablet
Comment 6 2016-06-03 08:09:33 PDT
Created attachment 280444 [details] Patch for landing
WebKit Commit Bot
Comment 7 2016-06-03 08:39:18 PDT
Comment on attachment 280444 [details] Patch for landing Clearing flags on attachment: 280444 Committed r201642: <http://trac.webkit.org/changeset/201642>
WebKit Commit Bot
Comment 8 2016-06-03 08:39:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.