Bug 158278

Summary: [JSC] Some setters for components of Date do not timeClip() their result
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews116 for mac-yosemite
none
Patch commit-queue: commit-queue-

Description Benjamin Poulain 2016-06-01 15:20:32 PDT
[JSC] Some setters for components of Date do not timeClip() their result
Comment 1 Benjamin Poulain 2016-06-01 15:27:56 PDT
Created attachment 280272 [details]
Patch
Comment 2 Geoffrey Garen 2016-06-01 15:39:53 PDT
Comment on attachment 280272 [details]
Patch

r=me
Comment 3 Build Bot 2016-06-01 16:28:25 PDT
Comment on attachment 280272 [details]
Patch

Attachment 280272 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1420107

New failing tests:
js/date-timeClip-large-values.html
Comment 4 Build Bot 2016-06-01 16:28:30 PDT
Created attachment 280276 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Benjamin Poulain 2016-06-01 18:24:36 PDT
Created attachment 280289 [details]
Patch
Comment 6 WebKit Commit Bot 2016-06-01 19:40:39 PDT
Comment on attachment 280289 [details]
Patch

Rejecting attachment 280289 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 280289, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/1420871
Comment 7 Benjamin Poulain 2016-06-01 20:33:12 PDT
Committed r201586: <http://trac.webkit.org/changeset/201586>