Bug 158278 - [JSC] Some setters for components of Date do not timeClip() their result
Summary: [JSC] Some setters for components of Date do not timeClip() their result
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-01 15:20 PDT by Benjamin Poulain
Modified: 2016-06-01 20:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.79 KB, patch)
2016-06-01 15:27 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (1.34 MB, application/zip)
2016-06-01 16:28 PDT, Build Bot 		no flags Details
Patch (19.20 KB, patch)
2016-06-01 18:24 PDT, Benjamin Poulain 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-06-01 15:20:32 PDT 
[JSC] Some setters for components of Date do not timeClip() their result
Comment 1 Benjamin Poulain 2016-06-01 15:27:56 PDT 
Created attachment 280272 [details]
Patch
Comment 2 Geoffrey Garen 2016-06-01 15:39:53 PDT 
Comment on attachment 280272 [details]
Patch

r=me
Comment 3 Build Bot 2016-06-01 16:28:25 PDT 
Comment on attachment 280272 [details]
Patch

Attachment 280272 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1420107

New failing tests:
js/date-timeClip-large-values.html
Comment 4 Build Bot 2016-06-01 16:28:30 PDT 
Created attachment 280276 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Benjamin Poulain 2016-06-01 18:24:36 PDT 
Created attachment 280289 [details]
Patch
Comment 6 WebKit Commit Bot 2016-06-01 19:40:39 PDT 
Comment on attachment 280289 [details]
Patch

Rejecting attachment 280289 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 280289, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/1420871
Comment 7 Benjamin Poulain 2016-06-01 20:33:12 PDT 
Committed r201586: <http://trac.webkit.org/changeset/201586>