Bug 158245

Summary: Bopomofo ruby in Dictionary.app is written horizontally (when it should be written vertically)
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch darin: review+

Myles C. Maxfield
Reported 2016-05-31 17:47:42 PDT
Bopomofo ruby in Dictionary.app is written horizontally (when it should be written vertically)
Attachments
WIP (3.38 KB, patch)
2016-05-31 17:48 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (7.32 KB, patch)
2016-06-01 18:38 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (344.93 KB, patch)
2016-06-01 19:02 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-05-31 17:48:32 PDT
Created attachment 280201 [details] WIP
Myles C. Maxfield
Comment 2 2016-05-31 17:49:34 PDT
<rdar://problem/25675318>
Myles C. Maxfield
Comment 3 2016-06-01 18:38:54 PDT
Created attachment 280291 [details] Patch
Myles C. Maxfield
Comment 4 2016-06-01 19:02:21 PDT
Created attachment 280293 [details] Patch
Darin Adler
Comment 5 2016-06-02 11:23:01 PDT
Comment on attachment 280293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280293&action=review > LayoutTests/ChangeLog:10 > + Rebaselined fast/table/border-collapsing/004-vertical.html. These results are pixel-identical in > + MiniBrowser and Safari, which means the old render tree dump was wrong. I really don’t understand the logic here. How does the fact that nothing changed visually mean that the old render tree dump was wrong? Are you saying we had a wrong render tree but somehow accidentally got exactly the right results displayed? Can we do something else for the future health of this test? Maybe turn it into a reference test? I guess not because it doesn’t fit into the viewport.
Myles C. Maxfield
Comment 6 2016-06-03 19:00:44 PDT
Comment on attachment 280293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280293&action=review >> LayoutTests/ChangeLog:10 >> + MiniBrowser and Safari, which means the old render tree dump was wrong. > > I really don’t understand the logic here. How does the fact that nothing changed visually mean that the old render tree dump was wrong? Are you saying we had a wrong render tree but somehow accidentally got exactly the right results displayed? Can we do something else for the future health of this test? Maybe turn it into a reference test? I guess not because it doesn’t fit into the viewport. It turns out that this comment is wrong - when I was comparing MiniBrowser and Safari, I resized the windows to get them to line up, which caused full relayouts, which papered over the problem. It turns out that the -expected.txt change is actually due to the creation of the horizontal scrollbar triggering a second layout. Before this patch, this second layout didn't descend deeply into the render tree, however, with this patch, it correctly does. It is a progression. I'll change the comment.
Myles C. Maxfield
Comment 7 2016-06-03 19:03:37 PDT
Committed r201677: <http://trac.webkit.org/changeset/201677>
Note You need to log in before you can comment on or make changes to this bug.