Bug 158233

Summary: [EME] Sound continues playing when video's src is changed
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jer Noble 2016-05-31 13:43:23 PDT 
[EME] Sound continues playing when video's src is changed
Comment 1 Jer Noble 2016-05-31 13:54:51 PDT 
Created attachment 280176 [details]
Patch
Comment 2 Jer Noble 2016-05-31 14:04:50 PDT 
Created attachment 280180 [details]
Patch
Comment 3 Eric Carlson 2016-05-31 14:18:27 PDT 
Comment on attachment 280180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280180&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2598
> +    std::unique_ptr<CDMSessionAVFoundationObjC> session = std::make_unique<CDMSessionAVFoundationObjC>(this, client);

Nit: can you use "auto" here?
Comment 4 Jer Noble 2016-05-31 14:20:51 PDT 
(In reply to comment #3)
> Comment on attachment 280180 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280180&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2598
> > +    std::unique_ptr<CDMSessionAVFoundationObjC> session = std::make_unique<CDMSessionAVFoundationObjC>(this, client);
> 
> Nit: can you use "auto" here?

Sure can!
Comment 5 Jer Noble 2016-05-31 14:23:07 PDT 
Committed r201524: <http://trac.webkit.org/changeset/201524>
Comment 6 Jer Noble 2016-05-31 14:23:28 PDT 
<rdar://problem/26248690>
Comment 7 Darin Adler 2016-06-01 23:13:19 PDT 
Comment on attachment 280180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280180&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2600
> +    return WTFMove(session);

No need for WTFMove here.