Bug 158233

Summary: [EME] Sound continues playing when video's src is changed
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jer Noble
Reported 2016-05-31 13:43:23 PDT
[EME] Sound continues playing when video's src is changed
Attachments
Patch (10.46 KB, patch)
2016-05-31 13:54 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (10.51 KB, patch)
2016-05-31 14:04 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-05-31 13:54:51 PDT
Created attachment 280176 [details] Patch
Jer Noble
Comment 2 2016-05-31 14:04:50 PDT
Created attachment 280180 [details] Patch
Eric Carlson
Comment 3 2016-05-31 14:18:27 PDT
Comment on attachment 280180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280180&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2598 > + std::unique_ptr<CDMSessionAVFoundationObjC> session = std::make_unique<CDMSessionAVFoundationObjC>(this, client); Nit: can you use "auto" here?
Jer Noble
Comment 4 2016-05-31 14:20:51 PDT
(In reply to comment #3) > Comment on attachment 280180 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280180&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2598 > > + std::unique_ptr<CDMSessionAVFoundationObjC> session = std::make_unique<CDMSessionAVFoundationObjC>(this, client); > > Nit: can you use "auto" here? Sure can!
Jer Noble
Comment 5 2016-05-31 14:23:07 PDT
Committed r201524: <http://trac.webkit.org/changeset/201524>
Jer Noble
Comment 6 2016-05-31 14:23:28 PDT
<rdar://problem/26248690>
Darin Adler
Comment 7 2016-06-01 23:13:19 PDT
Comment on attachment 280180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280180&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2600 > + return WTFMove(session); No need for WTFMove here.
Note You need to log in before you can comment on or make changes to this bug.