Bug 158225

Summary:

[Win] Potential null pointer crash when setting cursor.

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	achristensen: review+

Description Per Arne Vollan 2016-05-31 05:23:39 PDT

Code inspection shows that the call cursor.platformCursor() can return null.

void WebChromeClient::setCursor(const Cursor& cursor)
{
    HCURSOR platformCursor = cursor.platformCursor()->nativeCursor();
    ...

Comment 1 Per Arne Vollan 2016-05-31 05:32:42 PDT

Created attachment 280139 [details]
Patch

Comment 2 Alex Christensen 2016-05-31 09:52:35 PDT

Comment on attachment 280139 [details]
Patch

Sure

Comment 3 Per Arne Vollan 2016-06-01 02:13:50 PDT

(In reply to comment #2)
> Comment on attachment 280139 [details]
> Patch
> 
> Sure

Thanks for reviewing :)

Comment 4 Per Arne Vollan 2016-06-01 02:15:08 PDT

Committed r201546: <https://trac.webkit.org/changeset/201546>