| Summary: | AX: iOS: VoiceOver can't access attachments in mail messages | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||||||||||
| Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | Safari 9 | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
chris fleizach
2016-05-30 00:20:49 PDT
Created attachment 280075 [details]
Patch
There's no expected file right now. Couldn't make simulator run for me. Hoping build bots produce expected result
Created attachment 280169 [details]
Patch
Joanmarie: ready for review if you have a chance Comment on attachment 280169 [details] Patch Attachment 280169 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1413955 New failing tests: accessibility/ios-simulator/attributed-string-for-range.html Created attachment 280174 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
(In reply to comment #5) > Created attachment 280174 [details] > Archive of layout-test-results from ews126 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4 Ah, debug vs. Release -(NSString *)description not implemented in release Created attachment 280251 [details]
Patch
Created attachment 280252 [details]
Patch
Comment on attachment 280252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280252&action=review > Source/WebCore/ChangeLog:8 > + Replaced elements, like attachemnts, were not being exposed in the attributed string returned to VoiceOver. nit: attachments > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:65 > + NSAttachmentCharacter = 0xfffc /* To denote attachments. */ It looks like this will be the third place this character is being defined (the other two being editing/cocoa/HTMLConverter.mm and platform/mac/WebNSAttributedStringExtras.mm). Would it make sense to define it once in a platform header? Comment on attachment 280252 [details] Patch Clearing flags on attachment: 280252 Committed r201568: <http://trac.webkit.org/changeset/201568> All reviewed patches have been landed. Closing bug. (In reply to comment #9) > Comment on attachment 280252 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280252&action=review > > > Source/WebCore/ChangeLog:8 > > + Replaced elements, like attachemnts, were not being exposed in the attributed string returned to VoiceOver. > > nit: attachments > > > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:65 > > + NSAttachmentCharacter = 0xfffc /* To denote attachments. */ > > It looks like this will be the third place this character is being defined > (the other two being editing/cocoa/HTMLConverter.mm and > platform/mac/WebNSAttributedStringExtras.mm). Would it make sense to define > it once in a platform header? https://bugs.webkit.org/show_bug.cgi?id=158287 |