Bug 158186

Summary:

JSGlobalLexicalEnvironment leaks SegmentedVector due to lack of destructor.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

JavaScriptCore

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, keith_miller, mark.lam, msaboff, saam

Priority:

Keywords:

Performance

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Andreas Kling

Reported 2016-05-28 18:56:41 PDT

We're leaking all of the SegmentedVector backing stores from JSGlobalLexicalEnvironment since it doesn't get a destructor call.

Attachments
Proposed patch (3.07 KB, patch) 2016-05-28 18:57 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2016-05-28 18:57:33 PDT

Saam Barati

Comment 2 2016-05-28 20:23:36 PDT

Comment on attachment 280053 [details] Proposed patch r=me Nice catch

WebKit Commit Bot

Comment 3 2016-05-28 21:46:27 PDT

Comment on attachment 280053 [details] Proposed patch Clearing flags on attachment: 280053 Committed r201494: <http://trac.webkit.org/changeset/201494>

WebKit Commit Bot

Comment 4 2016-05-28 21:46:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.