Bug 158176

Summary: Improve lambda capture in NetworkCache::Storage::synchronize()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, cgarcia, commit-queue, darin, koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 158111    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-05-27 20:40:48 PDT
Improve lambda capture in NetworkCache::Storage::synchronize() by leveraging C++14's capture with initializer.
Attachments
Patch (2.19 KB, patch)
2016-05-27 20:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-05-27 20:43:32 PDT
Created attachment 280018 [details] Patch
Brady Eidson
Comment 2 2016-05-27 21:42:50 PDT
Comment on attachment 280018 [details] Patch Is capturing a protectedThis not necessary? I'm not sure, as I didn't look, but please confirm by yourself :)
Chris Dumez
Comment 3 2016-05-27 21:47:39 PDT
Comment on attachment 280018 [details] Patch Clearing flags on attachment: 280018 Committed r201480: <http://trac.webkit.org/changeset/201480>
Chris Dumez
Comment 4 2016-05-27 21:47:47 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 5 2016-05-27 21:48:19 PDT
(In reply to comment #2) > Comment on attachment 280018 [details] > Patch > > Is capturing a protectedThis not necessary? > > I'm not sure, as I didn't look, but please confirm by yourself :) No need, NetworkCacheStorage is owned by the NetworkCache, which is a singleton.
Note You need to log in before you can comment on or make changes to this bug.