Bug 158176

Summary: Improve lambda capture in NetworkCache::Storage::synchronize()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, cgarcia, commit-queue, darin, koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 158111    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2016-05-27 20:40:48 PDT 
Improve lambda capture in NetworkCache::Storage::synchronize() by leveraging C++14's capture with initializer.
Comment 1 Chris Dumez 2016-05-27 20:43:32 PDT 
Created attachment 280018 [details]
Patch
Comment 2 Brady Eidson 2016-05-27 21:42:50 PDT 
Comment on attachment 280018 [details]
Patch

Is capturing a protectedThis not necessary?

I'm not sure, as I didn't look, but please confirm by yourself :)
Comment 3 Chris Dumez 2016-05-27 21:47:39 PDT 
Comment on attachment 280018 [details]
Patch

Clearing flags on attachment: 280018

Committed r201480: <http://trac.webkit.org/changeset/201480>
Comment 4 Chris Dumez 2016-05-27 21:47:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2016-05-27 21:48:19 PDT 
(In reply to comment #2)
> Comment on attachment 280018 [details]
> Patch
> 
> Is capturing a protectedThis not necessary?
> 
> I'm not sure, as I didn't look, but please confirm by yourself :)

No need, NetworkCacheStorage is owned by the NetworkCache, which is a singleton.