Bug 158169 – Use COMPILER(MSVC) instead of PLATFORM(WIN) for MSVC-specific workaround

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Konstantin Tokarev]

Use COMPILER(MSVC) instead of PLATFORM(WIN) for MSVC-specific workaround.

[Konstantin Tokarev]

Created attachment 279999 [details]
Patch

[Darin Adler]

Comment on attachment 279999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279999&action=review

> Source/WebCore/platform/PlatformMouseEvent.h:152
> +    bool operator==(unsigned short a, MouseButton b)
> +    {
> +        return a == static_cast<unsigned short>(b);
> +    }
> +
> +    bool operator!=(unsigned short a, MouseButton b)
> +    {
> +        return a != static_cast<unsigned short>(b);
> +    }

These will need to be marked inline or we can get linker errors.

[Konstantin Tokarev]

Created attachment 280008 [details]
Patch

[Darin Adler]

Comment on attachment 280008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280008&action=review

> Source/WebCore/platform/PlatformMouseEvent.h:142
>      // These methods are necessary to work around the fact that MSVC will not find a most-specific

I would have said "functions", not "methods".

[Konstantin Tokarev]

Manually committed https://trac.webkit.org/r201485, addressing your comment.