Summary: | Fix the build with newer clang and other custom configuration options | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||||
Component: | WebKit Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, jer.noble, mitz | ||||||||||
Priority: | P2 | ||||||||||||
Version: | Other | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2016-05-27 12:48:37 PDT
Created attachment 279984 [details]
proposed fix
Attachment 279984 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Anders suggested marking *SPI.h headers as system headers using a pragma. I think we should do that instead of suppressing individual warning in them. Seems reasonable. How does one do that? I don't remember if we ever had any useful warnings in SPI headers, although I'm also not sure whether I would remember if we did. (In reply to comment #4) > Seems reasonable. How does one do that? #pragma clang system_header Created attachment 280003 [details]
with a pragma
Attachment 280003 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 280011 [details]
proposed fix
Reverted too much when changing CFNetworkSPI.h.
Attachment 280011 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 280011 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=280011&action=review > Source/WebCore/platform/spi/mac/AVFoundationSPI.h:68 > +@interface AVAssetCache (Details) We have stopped using categories for this, instead using class extensions, like in CFNetworkSPI.h above. > Source/WebKit2/ChangeLog:9 > + * NetworkProcess/ios/NetworkProcessIOS.mm: -setAllowsSpecificHTTPSCertificate:forHost: > + is not in CFNetworkSPI.h “not”? Created attachment 280047 [details]
patch for landing
Attachment 280047 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 280047 [details] patch for landing Clearing flags on attachment: 280047 Committed r201492: <http://trac.webkit.org/changeset/201492> All reviewed patches have been landed. Closing bug. |