Bug 158146

Summary: Video play glyph not visible if initially invisible when contained in a "-webkit-overflow-scrolling: touch" container
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: iOS 9.3   
Bug Depends on: 158147    
Bug Blocks:    
Attachments:
Description Flags
Reduction
none
Patch
none
Patch for landing none

Antoine Quint
Reported 2016-05-27 01:04:44 PDT
<rdar://problem/25816307>
Attachments
Reduction (473 bytes, text/html)
2016-05-27 01:05 PDT, Antoine Quint 		no flags
Details
Patch (5.19 KB, patch)
2016-05-27 01:20 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.39 KB, patch)
2016-05-27 06:20 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2016-05-27 01:05:47 PDT
Created attachment 279946 [details] Reduction
Radar WebKit Bug Importer
Comment 2 2016-05-27 01:06:44 PDT
<rdar://problem/26513556>
Radar WebKit Bug Importer
Comment 3 2016-05-27 01:06:49 PDT
<rdar://problem/26513543>
Antoine Quint
Comment 4 2016-05-27 01:15:39 PDT
If a <video> on iOS is contained within a "-webkit-overflow-scrolling: touch" container and is laid out such that its play button is not initially visible, the play glyph will be invisible until it's touched or a layout happens. The root of this issue is https://bugs.webkit.org/show_bug.cgi?id=158147, but this is tracking an ad-hoc fix to just the video controls.
Antoine Quint
Comment 5 2016-05-27 01:20:56 PDT
Created attachment 279948 [details] Patch
Antoine Quint
Comment 6 2016-05-27 01:33:10 PDT
Ideally the test would dump the layers in the shadow tree as well but I'm not sure if that's possible.
Dean Jackson
Comment 7 2016-05-27 04:59:56 PDT
Comment on attachment 279948 [details] Patch why don't you use a compositing test? that will show the layers.
Antoine Quint
Comment 8 2016-05-27 06:20:59 PDT
Created attachment 279955 [details] Patch for landing
Antoine Quint
Comment 9 2016-05-27 06:25:44 PDT
(In reply to comment #7) > Comment on attachment 279948 [details] > Patch > > why don't you use a compositing test? that will show the layers. Didn't really know about that ability, which is exactly what I needed. Updated the test to dump the layer tree when landing, it fails without this fix.
WebKit Commit Bot
Comment 10 2016-05-27 06:49:51 PDT
Comment on attachment 279955 [details] Patch for landing Clearing flags on attachment: 279955 Committed r201450: <http://trac.webkit.org/changeset/201450>
WebKit Commit Bot
Comment 11 2016-05-27 06:49:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.