Bug 158123
| Summary: | prepare-ChangeLog not picking up changes in a particular class | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chelsea Pugh <cpugh> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, cpugh, ddkilzer, jmarcell, lforschler, mitz |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chelsea Pugh
Related Radar for more information: rdar://problem/26423121
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jason Marcell
We have a method that looks something like this and prepareChangelog isn’t smart enough to know that there are preprocessor macros in play here so it thinks the curly braces are all mismatched, thus hindering its ability to understand where the method ends and the next method begins.
- (void)bar:(void (^)())block
{
#if __WHATEVER >= 12345
[blip foo:^(Fuzz *bar) {
if (buzz) {
dispatch_async(dispatch_get_main_queue(), ^{
#else
[blip foo:^(NSData *bing) {
if (buzz) {
dispatch_async(dispatch_get_main_queue(), ^{
_blah = baz.firstObject;
#endif
});
}
}];
}