| Summary: | Simplify a couple of lambda captures in the network cache code | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cgarcia, commit-queue, koivisto | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2016-05-24 20:48:20 PDT
Created attachment 279738 [details]
Patch
Comment on attachment 279738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279738&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:-902 > - // Avoid non-thread safe std::function copies. > - auto* completionHandlerPtr = completionHandler ? new std::function<void ()>(WTFMove(completionHandler)) : nullptr; I see this comment, and it makes me wonder - How much thread hopping does the NetworkCacheStorage code do? We have a mechanism for this called "createCrossThreadTask" that perhaps you should look in to going forward. Comment on attachment 279738 [details] Patch Clearing flags on attachment: 279738 Committed r201371: <http://trac.webkit.org/changeset/201371> All reviewed patches have been landed. Closing bug. |